Open
Conversation
(bug) Try connecting sockets without URL 3
aseiden
reviewed
May 20, 2017
client/src/components/Container.jsx
Outdated
| return ( | ||
| <div> | ||
| <Header /> | ||
| <Header handleFav={props.route.handleFav} /> |
aseiden
reviewed
May 20, 2017
| } | ||
|
|
||
| addToFav(e) { | ||
| console.log(this.props.college); |
aseiden
reviewed
May 20, 2017
|
|
||
| addToFav(e) { | ||
| console.log(this.props.college); | ||
| this.props.handleFav(this.props.college); |
There was a problem hiding this comment.
This will break when this entry is being rendered for the favorites because it won't be able to properly reference handleFav.
aseiden
reviewed
May 20, 2017
| }); | ||
| } | ||
|
|
||
| handleFavColleges(college) { |
There was a problem hiding this comment.
Let's try and do 2 big things with this:
- Let's write it so it toggles fav colleges on multiple clicks rather than adding the college over and over.
- Let's see if we can make it generic and pass it to FavoritesPage.jsx OR let's write a very similar function in there that adjusted to the state in FavoritesPage.jsx and passed to ResultsListEntry.jsx . This would permit us to remove favorites from the favorites page.
aseiden
reviewed
May 20, 2017
client/src/index.jsx
Outdated
| this.handleFav = this.handleFav.bind(this); | ||
| } | ||
|
|
||
| handleFav(){ |
There was a problem hiding this comment.
If this doesn't do anything, let's remove it.
aseiden
reviewed
May 20, 2017
| import CommentsPage from './components/CommentsPage.jsx'; | ||
|
|
||
| class App extends React.Component { | ||
| constructor(props){ |
There was a problem hiding this comment.
Let's remove this if it isn't doing anything.
…into feat/fresh-sesh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duuuuuuuude. Am Happy.